Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Bump core and web commit id #2100

Merged
merged 1 commit into from
Jun 2, 2021
Merged

[tests-only] Bump core and web commit id #2100

merged 1 commit into from
Jun 2, 2021

Conversation

SwikritiT
Copy link
Contributor

Description

This PR bumps core and web commit id to see if any tests are failing and add them to expected to fail file accordingly

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this May 31, 2021
@SwikritiT SwikritiT mentioned this pull request May 31, 2021
Closed
3 tasks
@phil-davis
Copy link
Contributor

@SwikritiT this needs to be rebased. A reva update was merged PR #2104 and that already removed a lot of scenarios from expected-failures.

@phil-davis
Copy link
Contributor

This is getting close now!
https://drone.owncloud.com/owncloud/ocis/5220/39/7
https://drone.owncloud.com/owncloud/ocis/5220/40/6
There are just some previews scenarios that are passing. They can be removed from expected-failures.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 947b3d6 into master Jun 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-20210531 branch June 2, 2021 07:30
ownclouders pushed a commit that referenced this pull request Jun 2, 2021
@phil-davis
commit 947b3d6
1c56e8e 
Merge: 1b4fe83 18b437c
Author: Phil Davis <phil@jankaritech.com>
Date:   Wed Jun 2 13:15:14 2021 +0545

    Merge pull request #2100 from owncloud/bump-commit-id-20210531

    [tests-only] Bump core and web commit id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @phil-davis